Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the base ubuntu package for ZFS plugin #68

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Upgrade the base ubuntu package for ZFS plugin #68

merged 1 commit into from
Mar 30, 2020

Conversation

stevefan1999-personal
Copy link
Contributor

*Addresses GLIBC incompatability
Probably fixes #67

@codecov-io
Copy link

Codecov Report

Merging #68 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   23.57%   23.57%           
=======================================
  Files          14       14           
  Lines         475      475           
=======================================
  Hits          112      112           
  Misses        362      362           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed9ce5...9333bee. Read the comment docs.

@kmova kmova requested a review from pawanpraka1 March 26, 2020 15:23
@pawanpraka1 pawanpraka1 mentioned this pull request Mar 27, 2020
Closed
@pawanpraka1
Copy link
Contributor

@stevefan1999-personal can you DCO signoff this commit?
https://github.com/openebs/zfs-localpv/blob/master/CONTRIBUTING.md#sign-your-work

@stevefan1999-personal @stevefan1999
Upgrade the base ubuntu package
a99f3dd 
*Addresses GLIBC incompatability
Probably fixes openebs#67

Signed-off-by: Steve Fan <29133953+stevefan1999-personal@users.noreply.github.com>
@stevefan1999-personal
Copy link
Contributor Author

@stevefan1999-personal can you DCO signoff this commit?
https://github.com/openebs/zfs-localpv/blob/master/CONTRIBUTING.md#sign-your-work

yep.

@pawanpraka1 pawanpraka1 added this to the v0.6.0 milestone Mar 30, 2020
@pawanpraka1 pawanpraka1 added the bug Something isn't working. label Mar 30, 2020
@pawanpraka1
Copy link
Contributor

pawanpraka1 commented Mar 30, 2020 •
edited
Loading

merging this to resolve the glibc issue. ZFS driver is not dependant on any library as of now except glbic and pthread libraries and since they are backward compatible, so I don't see any issue. We have to revisit this and find other ways to use the host's zfs binary so that we don't have to change the docker image with every release of ubuntu.

@pawanpraka1 pawanpraka1 merged commit 3e874ff into openebs:master Mar 30, 2020
@pawanpraka1 pawanpraka1 added this to Done in ZFS Local PV via automation Mar 30, 2020
@pawanpraka1 pawanpraka1 added this to Done in 1.9 Release Tracker - Due Apr 15th. via automation Mar 30, 2020
@kmova kmova added the Need community involvement Needs community involvement on some action item. label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanpraka1 pawanpraka1 pawanpraka1 left review comments

Assignees

@stevefan1999-personal stevefan1999-personal

Labels
bug Something isn't working. Need community involvement Needs community involvement on some action item.
Projects
ZFS Local PV
  
Done
1.9 Release Tracker - Due Apr 15th.
  
Done
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Cannot create ZFS volume due to outdated glibc
4 participants
@stevefan1999-personal @codecov-io @pawanpraka1 @kmova